Single Bucket - Delete object #67
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/single-bucket #67 +/- ##
=====================================================
Coverage ? 58.46%
=====================================================
Files ? 38
Lines ? 1712
Branches ? 0
=====================================================
Hits ? 1001
Misses ? 711
Partials ? 0 ☔ View full report in Codecov by Sentry. |
| @@ -25,7 +24,6 @@ async function invalidateCollab(api, url, env) { | |||
| } | |||
|
|
|||
| export async function deleteSource({ req, env, daCtx }) { | |||
| await postObjectVersion(req, env, daCtx); | |||
There was a problem hiding this comment.
IIUC this line here is to save a version of the file before deletion, so that it could be restored if the delete was accidental. I think it would be good to keep that.
/cc @karlpauls
There was a problem hiding this comment.
IIRC, there was a discussion about this (OOB). The problem was it didn't consider directories correctly. IMO it would make sense to keep it unless it causes big performance concerns but it would need to be only done for files and you'd have to evaluate the impact for large trees I guess.
There was a problem hiding this comment.
This was discussed on Slack w/ @auniverseaway , and the decision was to remove it.
bstopp
force-pushed
the
feat/sb-delete-object
branch
from
4e08a90 to
849fbbf
Compare
Description
Next step in getting to a single bucket: delete object
How Has This Been Tested?
Added unit & integration tests.
Screenshots (if appropriate):
Types of changes
Checklist: